Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): throw error when official docusaurus dependencies use different versions #9381

Merged
merged 3 commits into from
Oct 8, 2023
Merged

feat(core): throw error when official docusaurus dependencies use different versions #9381

merged 3 commits into from
Oct 8, 2023

Conversation

JorensM
Copy link
Contributor

@JorensM JorensM commented Oct 8, 2023 •
edited
Loading

Pre-flight checklist

Motivation

Test Plan

Related issues/PRs

#9342

@JorensM
feat(errors): throw error instead of just logging it when checking pl…
61e3fb0 
…ugin versions

additionally remove import for logger because it is not needed.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 8, 2023
@Josh-Cena
Copy link
Collaborator

Please, check for existing PRs before sending one. #9380

@Josh-Cena Josh-Cena closed this Oct 8, 2023
@Josh-Cena
Copy link
Collaborator

Sorry, I see you actually claimed the issue first!

@Josh-Cena Josh-Cena reopened this Oct 8, 2023
@Josh-Cena Josh-Cena mentioned this pull request Oct 8, 2023
Closed
3 tasks
@Josh-Cena Josh-Cena changed the title feat(errors): throw error instead of just logging it when checking plugin versions feat(core): throw error instead of just logging it when checking plugin versions Oct 8, 2023
@Josh-Cena
Copy link
Collaborator

Could you respect the PR template? Most importantly it asks you to link to the issue to intend to address because it will be automatically closed if you include text like "closes #xxxx".

@JorensM
Copy link
Contributor Author

JorensM commented Oct 8, 2023

@Josh-Cena Thanks for noticing haha. But if you think the other PR is better in some way, you can merge that one. Also I was using Gitpod to make this PR, and I think there should've been some extra info in the PR description that I should've added like a checklist.

@netlify
Copy link

netlify bot commented Oct 8, 2023 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit cc7fdd4
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6522d910e10bc100088dcdef
😎 Deploy Preview https://deploy-preview-9381--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 87 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 80 🟢 98 🟢 92 🟢 100 🟠 89 Report

@JorensM
Copy link
Contributor Author

JorensM commented Oct 8, 2023

@Josh-Cena The tests seem to have failed, but I'm not sure why. Could you take a look and explain why they're not passing?

@Josh-Cena
Copy link
Collaborator

The test logs are public and you can click on them. For example: https://github.com/facebook/docusaurus/actions/runs/6445635746/job/17499918105#step:5:1

The reason is because we have a test that expects mismatching plugins to log a message but run completely nontheless, while it now throws an error. You may take inspiration from the other PR to modify the test.

@JorensM
Copy link
Contributor Author

JorensM commented Oct 8, 2023

@Josh-Cena Thanks for explaining! I updated the test

@slorber slorber added pr: new feature This PR adds a new API or behavior. pr: polish This PR adds a very minor behavior improvement that users will enjoy. and removed pr: new feature This PR adds a new API or behavior. labels Oct 8, 2023
@slorber
Copy link
Collaborator

slorber commented Oct 8, 2023

Thanks 👍

@slorber slorber changed the title feat(core): throw error instead of just logging it when checking plugin versions feat(core): throw error when docusaurus deps are different Oct 8, 2023
@slorber slorber changed the title feat(core): throw error when docusaurus deps are different feat(core): throw error when official docusaurus dependencies use different versions Oct 8, 2023
@slorber slorber merged commit 1319996 into facebook:main Oct 8, 2023
29 of 31 checks passed
@slorber slorber linked an issue Oct 8, 2023 that may be closed by this pull request
Strict check for plugin version mismatch #9342
Closed
2 tasks
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strict check for plugin version mismatch
4 participants
@JorensM @Josh-Cena @slorber @facebook-github-bot